-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render style tags as plain text in md editor #429
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-423 |
15fd64f
to
35c3200
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have in the past used <style>
tags in text panels as a hacky way of applying CSS to specific products. Spencer recently made a change that allows us to create product-specific CSS files, so this PR should be fine. We may want to go back and look at previously created products and ensure that we aren't still using this old hacky method anymore.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have in the past used
<style>
tags in text panels as a hacky way of applying CSS to specific products
This is still currently the only way to add styles to a storylines product through the editor.
I'm hesitant to merge this as it takes away something possibly useful still in order to save a user from themselves. I think in the best case no one needs to add in style tags and therefore this should do nothing, and in the worst case this causes issues.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)
Related Item(s)
#423
Changes
v-md-editor
component, by replacing < and > with ‹ and › (respectively)v-md-editor
componentTesting
Steps:
<style>
tag (ex. with a forward slash at front/end, with whitespace in between, etc.)<style>
tag now have < and > replaced with ‹ and › (respectively)This change is